Tech-debt: pre-existing repo-wide ruff errors + non-hermetic systemd test #5

New issue

Closed

opened 2026-09-10 12:20:58 +00:00 by jmz · 1 comment

jmz commented

2026-09-10 12:20:58 +00:00

Owner

~11 pre-existing ruff check src errors in files the mesh milestones didn't touch (e.g. detectors/cert_expiry.py UP037, an S110 in engine.emit, RUF100s) — sweep in one pass.

Also tests/test_systemd_detector.py::test_no_run_capability_is_skipped fails on any host WITH systemd (shells to systemctl) — the one baseline failure throughout M1-M3. Make it hermetic (inject the runner) or skip when host systemd is present.

~11 pre-existing `ruff check src` errors in files the mesh milestones didn't touch (e.g. `detectors/cert_expiry.py` UP037, an `S110` in `engine.emit`, RUF100s) — sweep in one pass. Also `tests/test_systemd_detector.py::test_no_run_capability_is_skipped` fails on any host WITH systemd (shells to `systemctl`) — the one baseline failure throughout M1-M3. Make it hermetic (inject the runner) or skip when host systemd is present.

jmz added the

tech-debt

label

2026-09-10 12:20:58 +00:00

jmz commented

2026-09-10 16:17:43 +00:00

Author

Owner

Fixed in v0.18.0 (commit dadf719). Repo-wide ruff check src is now clean (S110 sites got real log lines or a justified noqa with rationale); the systemd baseline test is hermetic (injects the command runner) so the full suite is 0 failures.

Fixed in v0.18.0 (commit dadf719). Repo-wide `ruff check src` is now clean (S110 sites got real log lines or a justified noqa with rationale); the systemd baseline test is hermetic (injects the command runner) so the full suite is 0 failures.

jmz closed this issue

2026-09-10 16:17:44 +00:00