Polish: consolidated minor cleanups from M1-M3 reviews #4

New issue

Closed

opened 2026-09-10 12:20:57 +00:00 by jmz · 1 comment

jmz commented

2026-09-10 12:20:57 +00:00

Owner

Umbrella for cosmetic/robustness nits (none blocking):

resolve.py: params: [] falsy non-mapping silently collapses to {}; make the check is not None.
remediate.py: Tier0->Tier1 double-bumps reported attempts (cosmetic); _verify_timeout reaches Verifier._scheduler via getattr.
mesh/exec.py: bound_output(limit<marker) returns marker over-length; _str optional-empty comment; frozen dataclasses hold a mutable params dict.
mesh/invoke.py: pre-send rejects carry empty request_id; Invoker not kw-only; now hint is float.
config.py: _int default min_value=0 allows negatives; _read_secret_file no UnicodeDecodeError catch.
metrics.py: fresh/expired count could be one Counter pass; no test for zero-roles/caps agent.

Umbrella for cosmetic/robustness nits (none blocking): - `resolve.py`: `params: []` falsy non-mapping silently collapses to `{}`; make the check `is not None`. - `remediate.py`: Tier0->Tier1 double-bumps reported `attempts` (cosmetic); `_verify_timeout` reaches `Verifier._scheduler` via getattr. - `mesh/exec.py`: `bound_output(limit<marker)` returns marker over-length; `_str` optional-empty comment; frozen dataclasses hold a mutable `params` dict. - `mesh/invoke.py`: pre-send rejects carry empty `request_id`; `Invoker` not kw-only; `now` hint is `float`. - `config.py`: `_int` default `min_value=0` allows negatives; `_read_secret_file` no `UnicodeDecodeError` catch. - `metrics.py`: fresh/expired count could be one `Counter` pass; no test for zero-roles/caps agent.

jmz added the

polish

label

2026-09-10 12:20:57 +00:00

jmz referenced this issue from a commit

2026-09-10 16:17:17 +00:00

fix(mesh): T4 polish bag — resolve/exec/invoke/config robustness nits (#4)

jmz referenced this issue from a commit

2026-09-10 16:17:17 +00:00

remediate: mark_resolving None-race skip + coverage + nits + #7 comment (M6 T2)

jmz commented

2026-09-10 16:17:43 +00:00

Author

Owner

Fixed in v0.18.0 (commits fc2bd78 + e8d5348). resolve.py params guard -> is-not-None; exec.py bound_output marker clamp + documented mutable params; invoke.py pre-send request_id + kw-only + now float hint; config.py UnicodeDecodeError -> ConfigError. Two listed nits (config _int negative floor, metrics single-pass) were already correct and got regression tests instead.

Fixed in v0.18.0 (commits fc2bd78 + e8d5348). resolve.py params guard -> is-not-None; exec.py bound_output marker clamp + documented mutable params; invoke.py pre-send request_id + kw-only + now float hint; config.py UnicodeDecodeError -> ConfigError. Two listed nits (config _int negative floor, metrics single-pass) were already correct and got regression tests instead.

jmz closed this issue

2026-09-10 16:17:43 +00:00