Coverage gaps in Tier-0 remediation #3

New issue

Closed

opened 2026-09-10 12:20:57 +00:00 by jmz · 1 comment

jmz commented

2026-09-10 12:20:57 +00:00

Owner

M3 whole-branch review — named untested paths:

mark_resolving-returns-None race (see the correctness issue).
An auto: runbook with an empty allowed_tools now yields {outcome: no_action} where v0.14.0 launched a tool-less agent that escalated — defensible but undocumented/untested (changelog note + test).
_tier1_verify (verifier(cid, timeout_seconds=0)) must return after one detect with no sleep — add a direct test for timeout=0 + failing check.

**M3 whole-branch review — named untested paths:** - `mark_resolving`-returns-None race (see the correctness issue). - An `auto:` runbook with an **empty** `allowed_tools` now yields `{outcome: no_action}` where v0.14.0 launched a tool-less agent that escalated — defensible but undocumented/untested (changelog note + test). - `_tier1_verify` (`verifier(cid, timeout_seconds=0)`) must return after one detect with **no sleep** — add a direct test for timeout=0 + failing check.

jmz added the

coverage

label

2026-09-10 12:20:57 +00:00

jmz referenced this issue from a commit

2026-09-10 16:17:17 +00:00

remediate: mark_resolving None-race skip + coverage + nits + #7 comment (M6 T2)

jmz commented

2026-09-10 16:17:43 +00:00

Author

Owner

Fixed in v0.18.0 (commit e8d5348). Added the three named tests: mark_resolving-None race (Invoker never called, no escalate, gate released once); auto + empty allowed_tools -> no_action (with an intentional-behavior code comment); _tier1_verify timeout_seconds=0 returns after one detect with no sleep.

Fixed in v0.18.0 (commit e8d5348). Added the three named tests: mark_resolving-None race (Invoker never called, no escalate, gate released once); auto + empty allowed_tools -> no_action (with an intentional-behavior code comment); `_tier1_verify` timeout_seconds=0 returns after one detect with no sleep.

jmz closed this issue

2026-09-10 16:17:43 +00:00